fix: Result & DTOs for GetById + cleanup

TicketAppIncrArchi.Application/Services/TicketServices.cs

@@ -1,5 +1,7 @@
 using System.Runtime.CompilerServices;
+using System.Runtime.ExceptionServices;
 using Microsoft.AspNetCore.Http.HttpResults;
+using Microsoft.Extensions.ObjectPool;
 using TicketAppIncrArchi.Application.DTO;
 using TicketAppIncrArchi.Application.Interfaces;
 using TicketAppIncrArchi.Domain.Entities;
@@ -23,9 +25,24 @@ public class TicketService : ITicketService
     }
 
     
-    public Ticket? GetById(Guid id)
+    public Result<TicketResponse> GetById(Guid id)
     {
-        return _tickets.FirstOrDefault(ticket => ticket.Id == id);
+        //TODO: should use result 
+        var found = _tickets.FirstOrDefault(ticket => ticket.Id == id);
+        
+        if (found == null)
+        {
+            return Result<TicketResponse>.Fail("No Ticket Found");
+        }
+        
+        var ticketResponse = new TicketResponse
+        {
+            Id = found.Id,
+            Title = found.Title,
+            Description = found.Description,
+        };
+
+        return Result<TicketResponse>.Ok(found);
     } 
 
     public Result<CreateTicketResponse> Create(CreateTicketRequest request)
@@ -44,14 +61,14 @@ public class TicketService : ITicketService
         //send creation to repo
         _tickets.Add(ticket);
 
-        var response = new CreateTicketResponse 
+        var ticketResponse = new CreateTicketResponse 
         {
             Id = ticket.Id,
             Title = ticket.Title,
             Description = ticket.Description
         };
 
-        return Result<CreateTicketResponse>.Ok(response);
+        return Result<CreateTicketResponse>.Ok(ticketResponse);
         
     }